Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shuttle automatically called if round lasts 8 hours #32751

Merged
merged 2 commits into from Jun 9, 2022
Merged

Shuttle automatically called if round lasts 8 hours #32751

merged 2 commits into from Jun 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2022

[content]

What this does

Adds an actual shift time limit before the shuttle comes. Is recallable, but if recalled, will automatically keep calling every hour after that.

Why it's good

Stops server crashing due to "resource leakage" which usually happens 12 hours into a round, most rounds that manage to last this long are also usually deadpop.

Changelog

🆑

  • rscadd: Shifts now automatically call a shuttle after 8 hours. Recalling this will send it again an hour later each time it's recalled.

@PJBot PJBot added the Content Adds something. Neat! label Jun 6, 2022
@Eneocho
Copy link
Collaborator

Eneocho commented Jun 6, 2022

Make it so the recall message says "The shuttle will be called again in 1 hour." and we're golden.

@ghost
Copy link
Author

ghost commented Jun 6, 2022

Make it so the recall message says "The shuttle will be called again in 1 hour." and we're golden.

Or more accurately the time left until the next call or something.

@Hinaichigo
Copy link
Contributor

Hinaichigo commented Jun 6, 2022

Fixing the source of the resource leakage would be preferable. It's rare but I could imagine this getting in the way of potential super long We Build rounds. In some ideal universe the shuttle would only rarely have to be called and rounds would go on for days, stations getting increasingly customized, with people sleeping in dorms and antags being shuffled in by dynamic.

@ConfusedCactus
Copy link

ConfusedCactus commented Jun 6, 2022

shuttle autocalls 3 hours before we're allowed to bus

admeme bros....

@Servalfang
Copy link
Contributor

Fixing the source of the resource leakage would be preferable. It's rare but I could imagine this getting in the way of potential super long We Build rounds. In some ideal universe the shuttle would only rarely have to be called and rounds would go on for days, stations getting increasingly customized, with people sleeping in dorms and antags being shuffled in by dynamic.

if you really wanted that you would need a way to shuffle dead players back into the round as crew which i think is generally disliked

@Kurfursten
Copy link
Collaborator

Kurfursten commented Jun 7, 2022

If you can't be assed to swing by the bridge once an hour to recall, you really didn't want to build that bad.

I foresee this really only affecting the server when a round gets left on overnight due to 0 players.

@adacovsk
Copy link
Contributor

adacovsk commented Jun 7, 2022

It's not really an emergency if you're leaving after a full work day...

@Exxion
Copy link
Member

Exxion commented Jun 8, 2022

Yeah, ideally it wouldn't call it the emergency shuttle in this case, but that might be obnoxious to implement

@Kurfursten Kurfursten merged commit d92a442 into vgstation-coders:Bleeding-Edge Jun 9, 2022
@ghost ghost deleted the shiftend branch July 5, 2022 19:29
@bathosbathtime bathosbathtime mentioned this pull request Nov 13, 2022
@bathosbathtime
Copy link
Contributor

I know this is untested as the method used to call the shuttle can not be recalled and I doubt you would maliciously lie about being able to recall it if you knew better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content Adds something. Neat!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants