Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusts Pulse Demon and Prisoner Threat/Pop Requirements #33586

Merged
merged 1 commit into from
Oct 30, 2022
Merged

Adjusts Pulse Demon and Prisoner Threat/Pop Requirements #33586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/datums/gamemode/dynamic/dynamic_rulesets_latejoin.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
required_candidates = 1
weight = BASE_RULESET_WEIGHT
cost = 25
requirements = list(5,5,15,15,20,20,20,20,40,70)
requirements = list(70,40,20,20,20,20,15,15,5,5)
high_population_requirement = 10
logo = "pulsedemon-logo"

Expand Down
8 changes: 4 additions & 4 deletions code/datums/gamemode/dynamic/dynamic_rulesets_midround.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -823,7 +823,7 @@
required_candidates = 1
weight = BASE_RULESET_WEIGHT
cost = 20
requirements = list(5,5,15,15,20,20,20,20,40,70)
requirements = list(70,40,20,20,20,20,15,15,5,5)
high_population_requirement = 10
logo = "pulsedemon-logo"
var/list/cables_to_spawn_at = list()
Expand Down Expand Up @@ -914,11 +914,11 @@
restricted_from_jobs = list()
enemy_jobs = list("Warden","Head of Security")
required_enemies = list(1,1,1,1,1,1,1,1,1,1)
required_pop = list(0,0,10,10,15,15,20,20,20,25)
required_pop = list(25,20,20,20,15,15,10,10,0,0)
required_candidates = 1
weight = 3
weight = 1
Copy link
Contributor

@gurfan gurfan Oct 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BASE_RULESET_WEIGHT is equal to 10. Because the prisoner weight was set to three this made them LESS likely to appear.

Copy link
Collaborator Author

@jwhitak jwhitak Oct 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial PR had weight = 1. It was tripled due to Prisoner not firing often. I believe that Prisoner didn't fire often because of the backwards requirements, so I reverted the PR to buff the weight.

If you really think that it should be at 3, I can revert it.

cost = 0
requirements = list(5,5,15,15,20,20,20,20,40,70)
requirements = list(70,40,20,20,20,20,15,15,5,5)
high_population_requirement = 10
flags = MINOR_RULESET
makeBody = FALSE
Expand Down