Changes bicon() to use the builtin 515 feature #33764
Conversation
|
we are on 515, should this be merged or cleaned up? |
|
It would require us to require 515 clients, and there seem to be some issues with 515 clientside. I'm told it has crashing issues (though haven't seen it myself) and also the admin Special panel just doesn't seem to show up at all. The other skin issues seem to be fixed, though. |
|
Is this any closer to being mergeable? |
|
apparently so, the chicken has decreed 515 switch will be mandatory soon |
|
are we on 515 yet |
|
Before merging this, we should probably actually set the min client version to 515 so that people don't play on 514 and ask why examine icons are broken. I should also test it again just to make sure I didn't forget anything, but as far as I remember, this is ready |
|
will this close all the t-thanks BYOND issues with overlays looking bad on right click icons or not |
|
2 years man |
It won't have any effect on right click icons. Not directly, at least.
Part of that delay is our fault, but also Lummox took goddamn forever to release 515 into stable |
|
Testing found some significant bugs, which will probably be easy to fix when it's not 3 AM |
|
oh boy 3AM!!! |
|
it's always 3 AM somewhere in the world |
Obviously DNM until we're on 515.
515 makes this Just Work. It's clientside and even includes overlays (though not
vis_contents, which may or may not be a bug). Includes a couple hacks to ensure it works in edge cases. We could finally add examine icons back to humans with this. They never actually worked properly before, but they do with this.I should probably also excise all other uses of
icon2base64()as well but I haven't yetJust opening because I want to remember it and also clean up my local copy