Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panacea will now also remove the "suiciding" status #37335

Open
wants to merge 1 commit into
base: Bleeding-Edge
Choose a base branch
from
Open

Panacea will now also remove the "suiciding" status #37335

wants to merge 1 commit into from

Conversation

boy2mantwicethefam
Copy link
Contributor

Request

🆑

  • tweak: Suicide victims that are revived by Panacea will no longer quickly die again.

@Eneocho Eneocho added the Oversight Unintended consequence. label Dec 9, 2024
west3436
west3436 requested changes Dec 12, 2024
View reviewed changes
code/modules/reagents/reagents/reagents_medical.dm
@@ -92,11 +92,13 @@
..()
if(volume >= 0.2)
M.rejuvenate()
M?.mind.suiciding = 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to both of these, but the parent proc already checks for M existing so instead you'll want to use M.mind?.suiciding = 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@west3436 west3436 west3436 requested changes

Assignees
No one assigned
Labels
Oversight Unintended consequence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@boy2mantwicethefam @west3436 @Eneocho