Add more variety to traitor objectives #37395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the number and variety of traitor objectives, rather than always assigning a single assassinate and steal objective. Death/exit objectives (stay alive, die a glorious death, etc.) untouched.
west3436
requested changes
Jan 30, 2025
There was a problem hiding this comment.
Fix the possible infinite loop per @hacker-on-steroids please
|
is there a reason you're doing these branch merges/updates west? |
Linters were broken; I fixed them in #37399 so open PRs with failing checks had to merge the latest branch to pick up the fixes |
Prerolled objective indices via a shuffled list to increase efficiency.
…ion13 into Tator-Objectives
D3athrow-Issues
added a commit
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increases the number and variety of traitor objectives, rather than always assigning a single assassinate and steal objective. Death/exit objectives (stay alive, die a glorious death, etc.) untouched.
Fixes #37392.
What this does
Adds a new method for generating objectives for a traitor, trying between 2 and 5 with an attempt to limit duplicates to an extent.
Why it's good
For those who want inspiration or greentext it's a big improvement.
How it was tested
Locally.
Changelog
🆑