Use clad::zero_vector instead of 0 in the vectorized forward mode #1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
PetroZarytskyi
force-pushed
the
zero_vec
branch
from
97afee2
to
7714af5
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1140 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 50 50
Lines 8850 8850
=======================================
Hits 8362 8362
Misses 488 488
|
|
clang-tidy review says "All clean, LGTM! 👍" |
vgvassilev
reviewed
Nov 17, 2024
PetroZarytskyi
force-pushed
the
zero_vec
branch
from
576d015
to
906f05a
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Now the array is uninitialized. |
I think I understand the issue -- can you separate this PR into two separate ones? |
…ensure type safety. This is necessary to ensure type safety. ``0`` represents a zero vector but is only properly treated as a zero vector when it gets added/subtracted with a ``clad::array``. Initializing a ``clad::array`` with ``0`` will create not a zero vector but an empty array (with zero elements). To fix this, we needed exceptions for all declarations. We would need to make new exceptions when passing parameters to pushforwards.
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary to ensure type safety.
0represents a zero vector but is only properly treated as a zero vector when it gets added/subtracted with aclad::array. Initializing aclad::arraywith0will create not a zero vector but an empty array (with zero elements). To fix this, we needed exceptions for all declarations. We would need to make new exceptions when passing parameters to pushforwards.After merging this PR and #1121, #527 will be fixed automatically.