Update developer build process #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvassilev
reviewed
Jan 29, 2024
README.md
Outdated
| git clone https://github.com/vgvassilev/clad.git | ||
| cd clad | ||
| mkdir build && cd build | ||
| cmake -DLLVM_DIR=PATH/TO/llvm-project/build -DClang_DIR=PATH/TO/llvm-project/build -DCMAKE_BUILD_TYPE=DEBUG -DLLVM_EXTERNAL_LIT="$(which lit)" ../ |
There was a problem hiding this comment.
Do we need even -DClang_DIR when we have -DLLVM_DIR set?
There was a problem hiding this comment.
right, it is not required, resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 49 49
Lines 7190 7190
=======================================
Hits 6802 6802
Misses 388 388 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the developer build process to use the LLVM monorepo and builds clad externally.
Fixes #689