Removed incorrect deltaR squaring from object matching

[andresti]

The matchObjectCollection takes as input deltaR, not deltaR**2.
E.g. only matches with deltaR < 0.16 instead of deltaR < 0.4 were retained.

[arizzi]

@gpetruc

[gpetruc]

The square was correct until @cbernet changed the definition of matchObjectCollection from ΔR^2 to ΔR while "syncing utils: batchmanager" 9c4b27a
BTW changing the arguments of a function doesn't seem a great idea to me, as there may be many other places in heppy or vhbb or cmgtools where matchObjectCollection is used.

[cbernet]

Hi, it was changed to get a uniform signature for the various similar calls in this module. Some were taking Delta R^2 and some were taking Delta R. The change will have minimal impact now, and then it’s done. Colin

…

Le 9 févr. 2017 à 11:54, Giovanni Petrucciani ***@***.***> a écrit : The square was correct until @cbernet <https://github.com/cbernet> changed the definition of matchObjectCollection from ΔR^2 to ΔR while "syncing utils: batchmanager" 9c4b27a <9c4b27a> BTW changing the arguments of a function doesn't seem a great idea to me, as there may be many other places in heppy or vhbb or cmgtools where matchObjectCollection is used. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#662 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AD8ku3kcM297gRJ2SKxBUvMPk3GoJeV1ks5ravBJgaJpZM4L28BT>.

[arizzi]

minimal? we just run > 100k jobs on grid with all our matching messed up, how is it minimal?!?!?