Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubernetes and Knative cluster setup for arm devices #971

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Conversation

yulinzou
Copy link
Contributor

Summary

Support stock-only k8s and knative cluster setup for arm64/amd64 ubuntu 18.04 devices.

Implementation Notes ⚒️

  • Removed restrictions in setup scripts for arm architecture
  • Edit installation paths to support arm devices

External Dependencies 🍀

  • N/A

Breaking API Changes ⚠️

  • N/A

@yulinzou yulinzou requested a review from ustiugov April 11, 2024 11:09
Copy link
Contributor

@leokondrashov leokondrashov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please fix minor issues

scripts/utils/system.go Outdated Show resolved Hide resolved
configs/registry/repository-update-hosts.yaml Outdated Show resolved Hide resolved
Signed-off-by: Zou Yulin <yulin.zou@outlook.com>
@lrq619
Copy link
Collaborator

lrq619 commented Apr 12, 2024

@yulinzou Since go version of vHive has been downgraded, please rebase your current branch on master branch, and check again if it breaks the unit tests

Copy link
Collaborator

@lrq619 lrq619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@lrq619 lrq619 merged commit cc52682 into main Apr 15, 2024
23 checks passed
@lrq619 lrq619 deleted the arm-setup branch April 15, 2024 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants