Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MHPY-17 Return true for successful POST request #11

Merged
merged 1 commit into from
Jul 11, 2023
Merged

MHPY-17 Return true for successful POST request #11

merged 1 commit into from
Jul 11, 2023

Conversation

spacid
Copy link
Contributor

@spacid spacid commented Jul 11, 2023

The POST request returned None when the request is successful but contains no body e.g. response with status 204. It should return True in that case.

@spacid
MHPY-17 Return true for successful POST request
872a56f 
The POST request returned None when the request is successful but contains
no body e.g. response with status 204. It should return True in that case.
@spacid spacid requested a review from maartends July 11, 2023 13:15
maartends
maartends approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member

@maartends maartends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spacid spacid merged commit a269eec into main Jul 11, 2023
@spacid spacid deleted the mhpy-17-return-true-when-succussful-post-request branch July 11, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maartends maartends maartends approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spacid @maartends