MHPY-20 Allow zero start and end frames #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to fill in zero frames. In this context the truthy check incorrectly labels zero frames as false and thus not accepting the zero value. Explicitly check if the frames are not None instead.
maartends
approved these changes
Jul 13, 2023
Add an extra test checking that mixed frames/timecode values are not allowed. More specifically, use a frames value of 0 as this a valid value for frames.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should be possible to fill in zero frames. In this context the truthy check incorrectly labels zero frames as false and thus not accepting the zero value. Explicitly check if the frames are not None instead.