Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

POS-2131: Mobile Provider As String #84

Merged
merged 1 commit into from
Oct 26, 2023
Merged

POS-2131: Mobile Provider As String #84

merged 1 commit into from
Oct 26, 2023

Conversation

dylan-mcnamara-sh
Copy link
Collaborator

Descriptions

  1. Make mobile provider into a flexible string to align with changes and to make more robust for future updates.
  2. Repurposed Enum into static constant string class

Testing:

  1. Passed in null (no change)
  2. Passed in string (used one of the constants

@dylan-mcnamara-sh dylan-mcnamara-sh merged commit ee0163e into master Oct 26, 2023
1 check passed
@dylan-mcnamara-sh dylan-mcnamara-sh deleted the POS-2131-MobileProviderUpdate branch October 26, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxime-nanouche-sh maxime-nanouche-sh maxime-nanouche-sh approved these changes

@long-ly-sh long-ly-sh long-ly-sh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dylan-mcnamara-sh @long-ly-sh @maxime-nanouche-sh