Vial Support for Cantor #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's missing the default keymap, you should add it so that the build succeeds |
|
I have added the default keymap. |
|
Looks like it's still failing to compile |
xyzz
requested changes
Apr 9, 2022
keyboards/cantor/rules.mk
Outdated
Comment on lines
4
to
5
| VIA_ENABLE = yes # Enable VIA | ||
| VIAL_ENABLE = yes # Enable VIAL |
There was a problem hiding this comment.
this should go inside a keymap
There was a problem hiding this comment.
Alright I moved those lines into keyboards/cantor/vial/rules.mk
nowyouare
pushed a commit
to nowyouare/vial-qmk-ydkb
that referenced
this pull request
May 20, 2022
* Porting Cantor * Fixed unlock combo coordinates * Removed extra rules file * Added default keymap * Fixed rules.mk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello I'd like to add Vial support for the Cantor. I believe I've set everything up correctly. Please advise if there are any changes that are required.