Port Keychron Q11 to VIAL #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in that case, please open PR as draft and then change it when it's ready |
|
@xyzz, the Q11 has been merged into upstream |
lesshonor
pushed a commit
to lesshonor/vial-qmk
that referenced
this pull request
Apr 13, 2023
* Port Keychron Q11 to VIAL * Add back removed `KC_TASK` and `KC_FLXP` keycodes in `default` and `via` keymaps * Sync #20125 from `qmk/master`
|
@adophoxia does rgb control work for you? Any change I make (effect, brightness, toggle) applies only to the left side? |
lesshonor
pushed a commit
to lesshonor/vial-qmk
that referenced
this pull request
Jun 15, 2023
* Port Keychron Q11 to VIAL * Add back removed `KC_TASK` and `KC_FLXP` keycodes in `default` and `via` keymaps * Sync #20125 from `qmk/master`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
(Currently following qmk/qmk_firmware#20125, so will be syncing changes via cherry-picked commits to follow what is done with this PR, so best to leave this open if possible for until this PR gets merged)
Changes (for VIAL compatibility)
bool rgb_matrix_indicators_advanced_kb(uint8_t led_min, uint8_t led_max){tovoid rgb_matrix_indicators_advanced_kb(uint8_t led_min, uint8_t led_max){due to Explicitly mention kb/user callbacks as boolean qmk/qmk_firmware#18448 not being implemented in VIAL.RGB_MATRIX_LED_COUNTtoDRIVER_LED_TOTALinq11/config.handq11/ansi_encoder/ansi_encoder.cMC_1-5keycodes back toMACRO01-05KC_MCTLandKC_LPADkeycodes fromdefaultandviakeymaps