Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Keychron C2 Pro V2 White #746

Closed

Conversation

StandingPadAnimations
Copy link

@StandingPadAnimations StandingPadAnimations commented Jun 9, 2024

This patch adds support for the Keychron C2 Pro V2 White, ported from the Keychron fork of QMK. The files for V1 and the V2 RGB model have been removed in the porting process however, since I can't test those. EDIT: these are back in

This patch adds support for the Keychron C2 Pro V2 White, ported from
the Keychron fork of QMK. The files for V1 and the V2 RGB model have been
removed in the porting process however, since I can't test those.

Signed-off-by: Mahid Sheikh <mahid@standingpad.org>
Signed-off-by: Mahid Sheikh <mahid@standingpad.org>
Signed-off-by: Mahid Sheikh <mahid@standingpad.org>
@xyzz
Copy link
Contributor

xyzz commented Jul 21, 2024

there are a bunch of conflicts in this pr, please don't touch files that upstream qmk uses

@StandingPadAnimations
Copy link
Author

StandingPadAnimations commented Jul 24, 2024

The moving of the ansi folder to ansi_v1 was to match the Keychron fork of QMK, since there are 2 versions of the C2 Pro (and I'm using V2)

@xyzz
Copy link
Contributor

xyzz commented Jul 24, 2024

if it's diverged from the upstream qmk then it will be too much effort for vial to maintain conflicts on every qmk merge, and such pr will not be accepted

@xyzz xyzz closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants