Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add VIAL support for xt60_singa #824

Merged
merged 1 commit into from
Jan 25, 2025
Merged

feat: add VIAL support for xt60_singa #824

merged 1 commit into from
Jan 25, 2025

Conversation

Blood13
Copy link
Contributor

@Blood13 Blood13 commented Dec 3, 2024

So, the firmware for the xt60_singa is ready.

  • Support for both VIA and VIAL (except for the Key Override function due to the image size limitations).
  • Fixed a bug with the inverted CapsLock, relevant for white hot-swap boards. When CapsLock was pressed (LED lit up), lowercase letters were typed, and vice versa: when it was off, uppercase letters were typed. Essentially, the CapsLock LED was always on in its normal state, which was extremely annoying.

Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this was an ARM board these would just be nitpicks, but atmega32u4 (especially with RGB enabled) needs all the help it can get to keep filesize down.

Comment on lines +37 to +48
),

// Fn2 Layer
[2] = LAYOUT_all(
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS
),
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to hardcode filler KC_TRNS layers. Dynamic keymaps will automatically fill in "missing" layers at compile-time up to the maximum set in dynamic_keymap.layer_count. (By default, this is 4.)

Suggested change
),
// Fn2 Layer
[2] = LAYOUT_all(
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS
),
};
)
};

Comment on lines +2 to +4
"name": "XT60_SINGAKBD",
"vendorId": "0x4B50",
"productId": "0x0601",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"name": "XT60_SINGAKBD",
"vendorId": "0x4B50",
"productId": "0x0601",

These attributes are not used by Vial.

@xyzz xyzz merged commit efa99ef into vial-kb:vial Jan 25, 2025
3 checks passed
shadow-absorber pushed a commit to shadow-absorber/vial-qmk that referenced this pull request Jan 25, 2025
@Blood13
Copy link
Contributor Author

Blood13 commented Jan 25, 2025

I've missed the discussion. It's allright, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants