[RSDK-830] add DependsOn and models to serviceConfig #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran dist/buf locally. I think the CI is a bit buggy rn and might have to manually merge |
cheukt
approved these changes
Oct 27, 2022
| @@ -81,6 +81,7 @@ message ServiceConfig { | |||
| string namespace = 2; | |||
| string type = 3; | |||
| google.protobuf.Struct attributes = 4; | |||
| repeated string depends_on = 5; | |||
There was a problem hiding this comment.
we need to add models here too - maybe add it in this PR and then make a separate ticket for the associated changes in rdk/app
There was a problem hiding this comment.
Good call, making a ticket in jira. Added in models
Kschappacher
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed change for the adding dependencies to Service change: viamrobotics/rdk#1518