Skip to content

DOCS-2957: Change docs for Modularize Components epic #3668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 12, 2024

Conversation

martha-johnston
Copy link
Contributor

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Nov 11, 2024
@@ -95,7 +95,7 @@ For more information, see [Camera Component](/components/camera/).

{{<imgproc src="appendix/try-viam/rover-resources/viam-rover/accelerometer.jpg" resize="400x" declaredimensions=true alt="A ADXL345 accelerometer" >}}

The [ADXL345](/components/movement-sensor/adxl345/) sensor manufactured by Analog Devices is a digital 3-axis accelerometer that can read acceleration up to ±16g for high-resolution (13-bit) measurements.
The [ADXL345](https://github.com/viam-modules/analog-devices/tree/main/adxl345) sensor manufactured by Analog Devices is a digital 3-axis accelerometer that can read acceleration up to ±16g for high-resolution (13-bit) measurements.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here, and pretty much everywhere else I replaced links, I linked to the specific folder of the model in question. would you prefer I instead link to either the repo at the top level which could contain multiple models, to the readme itself, or to the section in the readme about configuring the model in questions?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer we link to the repo at the top level so people can see the configuring info, exactly. I can change that

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that also future proofs it if model names change etc

@martha-johnston
Copy link
Contributor Author

for the failing lint issues, it's because the links in the changelog don't exist anymore. I assumed I should not touch the changelog, but should I fix those links?

@npentrel
Copy link
Collaborator

Thank you @martha-johnston for your work on this, I can fix up the links and will do a quick review of the readmes too

@npentrel npentrel self-requested a review November 12, 2024 13:20
Comment on lines 57 to 60
| gripper | [`softrobotics`]() |
| motor | [`encoded-motor`]() |
| motor | [`gpiostepper`]() |
| motor | [`roboclaw`]() |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@martha-johnston what happened with these? Have they just been removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

softrobotmics is removed, encoded-motor and gpiostepper have no changes, and roboclaw was modularized but it's in my namespace instead of the viam namespace

| power sensor | [`ina219`](https://github.com/viam-modules/texas-instruments) |
| power sensor | [`ina226`](https://github.com/viam-modules/texas-instruments) |
| sensor | [`bme280`](https://github.com/viam-modules/bosch) |
| sensor | [`ds18b20`]() |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in my namespace instead of the viam namespace

@viambot
Copy link
Member

viambot commented Nov 12, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3668

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok - is there anything we need to wait for before merging?

@npentrel npentrel changed the title DOCS-2957: Documentation for Modularize Components epic DOCS-2957: Change docs for Modularize Components epic Nov 12, 2024
@martha-johnston
Copy link
Contributor Author

Ok - is there anything we need to wait for before merging?

It's up to you, technically these components still exist in rdk, they won't be removed until next week and maybe some the week after. but the modules already exist and are usable. basically there's two versions of all these components right now. we can either keep using the existing docs until those components are deleted from rdk, or start pointing to the module documentation now. I have no opinion on this

@npentrel
Copy link
Collaborator

I think might as well merge now

@npentrel npentrel merged commit bcbdd0f into viamrobotics:main Nov 12, 2024
9 checks passed
@martha-johnston
Copy link
Contributor Author

cool thanks @npentrel !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants