Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOCS-3838: Move tutorials page back to old link #4146

Merged
merged 3 commits into from
Apr 8, 2025
Merged

DOCS-3838: Move tutorials page back to old link #4146

merged 3 commits into from
Apr 8, 2025

Conversation

npentrel
Copy link
Collaborator

No description provided.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Mar 25, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 25, 2025 •
edited
Loading

✅ Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 3f1aaa5
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/67f5132fd607430008575c6a
😎 Deploy Preview https://deploy-preview-4146--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 37 (🔴 down 15 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

JessamyT
JessamyT reviewed Mar 25, 2025
View reviewed changes
Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be on /dev/tools/tutorials/?

@npentrel npentrel changed the title Add alias for tutorials Move tutorials page back to old link Mar 25, 2025
@JessamyT
Copy link
Collaborator

Now this results in this:
image
where both "tutorials" in left nav are clickable and go to the same place. Meanwhile if I click the "tutorials" breadcrumb it takes me to the docs landing page.

@npentrel npentrel changed the title Move tutorials page back to old link DOCS-3838: Move tutorials page back to old link Apr 8, 2025
JessamyT
JessamyT approved these changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@JessamyT JessamyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npentrel npentrel merged commit b9a75a5 into main Apr 8, 2025
13 checks passed
@npentrel npentrel deleted the npentrel-patch-3 branch April 8, 2025 18:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JessamyT JessamyT JessamyT approved these changes

Assignees
No one assigned
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@npentrel @JessamyT @viambot