RSDK-7422 - update webrtc crate #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
approved these changes
May 16, 2024
purplenicole730
approved these changes
May 16, 2024
stuqdog
force-pushed
the
update-webrtc-crate
branch
from
2eaafac
to
154719d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were pointing to a specific git commit for the webRTC crate to push past some buggy code that was breaking connectivity to esp32s. Now the latest webRTC crate release has that commit, so we should point to the official release rather than a github commit. Tested, confirmed that connection to an esp32 worked.
Updating
interceptorwas necessary for compatibility with the latestwebRTCcrate.