Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

DATA-723 Set Max Message Size for SLAM to 32 MB (SLAM) #117

Merged
7 commits merged into from Dec 12, 2022
Merged

DATA-723 Set Max Message Size for SLAM to 32 MB (SLAM) #117

7 commits merged into from Dec 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 9, 2022

gRPC limits the max size of bytes that can be sent to 4MB by default. The limit in most of RDK is 32MB however this also must be set in the SLAM algorithm's grpc system.

JIRA Ticket: DATA-723
Associated PR: #1658

jeremyhyde-viam added 2 commits December 9, 2022 17:53
@ghost ghost requested review from kkufieta and JohnN193 December 9, 2022 23:38
Copy link
Member

@JohnN193 JohnN193 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only question is does the maxMessageSize need to be a global variable?

Copy link
Contributor

@kkufieta kkufieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - though I agree with John, have it inline and add a comment as to why we chose 32 MB, e.g., like this:

// Increasing the gRPC max message size from the default value of 4MB to 32MB,
// to match the limit that is set in RDK. This is necessary for transmitting large
// pointclouds.
builder.SetMaxSendMessageSize(32 * 1024 * 1024);

@ghost ghost merged commit 43dc613 into viamrobotics:main Dec 12, 2022
@ghost ghost deleted the DATA-723_MaxMapReturn branch December 29, 2022 19:46
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants