fixed 065_encode_struct case

viant · Jun 12, 2024 · d5f129d · d5f129d
1 parent e7f1bd0
commit d5f129d
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/e2e/local/regression/cases/065_encode_struct/test.yaml b/e2e/local/regression/cases/065_encode_struct/test.yaml
@@ -5,7 +5,7 @@ pipeline:
     action: http/runner:send
     requests:
       - Method: GET
-        URL: 'http://127.0.0.1:8080/v1/api/dev/vendors-check?ids=[2/101/2]'
+        URL: 'http://127.0.0.1:8080/v1/api/dev/vendors-check?ids=2/101/2,2/101/2'
         Expect:
           JSONBody: $LoadJSON('${parentPath}/expect.json')
 
diff --git a/internal/translator/output.go b/internal/translator/output.go
@@ -299,7 +299,9 @@ func (s *Service) adjustCodecType(parameter *state.Parameter, types *xreflect.Ty
 		output.Schema.Name = name
 		output.Schema.Package = pkg
 		output.Schema.DataType = name
-		output.Schema.Cardinality = parameter.Schema.Cardinality
+		if parameter.Schema.Cardinality == state.Many {
+			output.Schema.Cardinality = parameter.Schema.Cardinality
+		}
 	case codec.KeyFirebaseAuth:
 		if len(output.Args) < 2 {
 			return fmt.Errorf("%v invalid arguments count", output.Name)

diff --git a/view/state/type.go b/view/state/type.go
@@ -239,7 +239,9 @@ func BuildSchema(field *reflect.StructField, pTag *tags.Parameter, result *Param
 		lookupType = extension.Config.Types.Lookup
 	}
 	rawType := field.Type
+	isSlice := false
 	if rawType.Kind() == reflect.Slice {
+		isSlice = true
 		rawType = rawType.Elem()
 	}
 	if rawType.Kind() == reflect.Ptr {
@@ -248,10 +250,16 @@ func BuildSchema(field *reflect.StructField, pTag *tags.Parameter, result *Param
 	rawName := rawType.Name()
 	if pTag.DataType != "" {
 		result.Schema = &Schema{Name: pTag.DataType}
+		if isSlice {
+			result.Schema.Cardinality = Many
+		}
 		if result.Output == nil {
 			result.Schema.SetType(field.Type)
 		} else if result.Output.Schema == nil {
 			result.Output.Schema = &Schema{}
+			if isSlice {
+				result.Output.Schema.Cardinality = Many
+			}
 			result.Output.Schema.SetType(field.Type)
 			setter.SetStringIfEmpty(&result.Output.Schema.DataType, rawName)
 		}