-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add agat sp merge annotations #106
Conversation
input_files="" | ||
IFS=";" read -ra file_names <<< "$par_gff" | ||
for file in "${file_names[@]}"; do | ||
input_files+="--gff $file " | ||
done | ||
unset IFS | ||
|
||
# run agat_sp_merge_annotations | ||
agat_sp_merge_annotations.pl \ | ||
$input_files \ | ||
-o "$par_output" \ | ||
${par_config:+--config "${par_config}"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test if the following works?
A couple of things here:
- If you set an environment variable as part of a composite command instead of on a separate line, it is only applied for the commands on that line (here IFS is only used by
read
, so no need to useunset
afterwards) - The
${array[@]}
syntax can be used to output an array which is seprated by spaces (space is the default separator, this can be adjusted)
input_files="" | |
IFS=";" read -ra file_names <<< "$par_gff" | |
for file in "${file_names[@]}"; do | |
input_files+="--gff $file " | |
done | |
unset IFS | |
# run agat_sp_merge_annotations | |
agat_sp_merge_annotations.pl \ | |
$input_files \ | |
-o "$par_output" \ | |
${par_config:+--config "${par_config}"} | |
IFS=";" read -ra file_names <<< "$par_gff" | |
# run agat_sp_merge_annotations | |
agat_sp_merge_annotations.pl \ | |
$input_files \ | |
-o "$par_output" \ | |
${file_names[@]} \ | |
${par_config:+--config "${par_config}"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not, the input should be in this format: --gff input1.gff --gff input2.gff
Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
Co-authored-by: Dries Schaumont <5946712+DriesSchaumont@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some minor formatting changes to config
Description
Issue ticket number
Closes #xxxx
Checklist before requesting a review
I have performed a self-review of my code
Conforms to the Contributing guidelines
Proposed changes are described in the CHANGELOG.md
I have tested my code with
viash ns test --parallel -q <name or namespace>
Check the correct box. Does this PR contain: