Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple components #162

Merged
merged 17 commits into from
Nov 8, 2024
Merged

Fix multiple components #162

merged 17 commits into from
Nov 8, 2024

Conversation

sainirmayi
Copy link
Contributor

@sainirmayi sainirmayi commented Oct 23, 2024

Description

  • bbmap_bbsplit: Fix argument type of --build to file and add output argument --index.
  • kallisto_index: Fix --threads option.
  • kallisto_quant: Fix output argument type and add output log file.
  • rsem_calculate_expression: Fix command and output files.
  • sortmerna: Fix output arguments and update docker image.
  • umi_tools_extract: Remove --umi_discard_reads option and fix --log2stderr argument.

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

Copy link
Contributor

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all of these fixes! Some minor questions 😊

Could you add entries to the changelog for all of the components that were fixed?

src/bbmap_bbsplit/config.vsh.yaml Outdated Show resolved Hide resolved
src/bbmap_bbsplit/config.vsh.yaml Show resolved Hide resolved
src/bbmap_bbsplit/config.vsh.yaml Outdated Show resolved Hide resolved
src/bbmap_bbsplit/script.sh Outdated Show resolved Hide resolved
src/kallisto/kallisto_quant/config.vsh.yaml Outdated Show resolved Hide resolved
src/kallisto/kallisto_quant/script.sh Outdated Show resolved Hide resolved
@sainirmayi sainirmayi requested a review from rcannood October 28, 2024 09:56
@rcannood rcannood merged commit b3fcd52 into main Nov 8, 2024
7 checks passed
@rcannood rcannood deleted the fix_multiple_components branch November 8, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants