Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: cutadapt base quality cutoff arguments have the wrong type #66

Closed
wants to merge 2 commits into from

Conversation

DriesSchaumont
Copy link
Contributor

@DriesSchaumont DriesSchaumont commented Jun 25, 2024

Description

Issue ticket number

Closes #xxxx

Checklist before requesting a review

  • I have performed a self-review of my code

  • Conforms to the Contributing guidelines

  • Proposed changes are described in the CHANGELOG.md

  • I have tested my code with viash ns test --parallel -q <name or namespace>

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Documentation
    • Bug fixes

@DriesSchaumont
Copy link
Contributor Author

DriesSchaumont commented Jun 26, 2024

Closing, it seems that it is possible to provide multiple values for this argument (e.g. -q "20,30"). Its possible to use multiple: true, but there are problems with providing nullable types for these. See viash-io/viash#705

@rcannood rcannood deleted the bug/cutadapt_quality_cutoff_wrong_type branch July 4, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant