Add callable workflows #38
Conversation
.github/workflows/build.yaml
Outdated
|
|
||
| if [[ -z $VERSION ]]; then | ||
| TARGET_BRANCH="build/$SOURCE_BRANCH" | ||
| VERSION=$(echo $TARGET_BRANCH | sed 's/[^a-zA-Z0-9_]/_/g') |
There was a problem hiding this comment.
Might be a good idea to quote here because $TARGET_BRANCH could (but should not) contain any weird characters
| version: ${{ steps.variables.outputs.version }} | ||
|
|
||
| - name: Deploy to target branch | ||
| uses: peaceiris/actions-gh-pages@v4 |
There was a problem hiding this comment.
This will not work with symbolic links, but does work when the branch already exists, right?
There was a problem hiding this comment.
Exactly. I'd be up for replacing this step.
|
|
||
|
|
||
| - uses: viash-io/viash-actions/project/build-target@v6 | ||
| id: build-target |
There was a problem hiding this comment.
Question: this already removes .gitignore stuff, right?
There was a problem hiding this comment.
Indeed!
- updates the gitignore
- sets the .version in _viash.yaml
- builds the target dir
- builds the nextflow schemas
- builds the nextflow param files
- create a matrix of docker executables which still need their docker image built
| run: | | ||
| ${{matrix.component.executable}} ---engine docker ---setup build ---verbose | ||
|
|
||
| - name: Push image |
There was a problem hiding this comment.
Sometimes it might be nice not to update containers (e.g. a release build). Perhaps add this option?
Two options here:
- Add another argument to specify the target_tag to use.
- Just not build the containers and assume they are already there given the provided tag
There was a problem hiding this comment.
Makes sense. Can I call the argument something like reuse_preexisting_docker_tag?
There was a problem hiding this comment.
I renamed it to: retag_image_tag
There was a problem hiding this comment.
Untested functionality tho! 🤪
|
|
||
|
|
||
| - uses: viash-io/viash-actions/project/build-target@v6 | ||
| id: build-target |
There was a problem hiding this comment.
Indeed!
- updates the gitignore
- sets the .version in _viash.yaml
- builds the target dir
- builds the nextflow schemas
- builds the nextflow param files
- create a matrix of docker executables which still need their docker image built
New functionality
.github/workflows/build.yaml: Added a callable workflow for building Viash components (PR #38)..github/workflows/test.yaml: Added a callable workflow for testing Viash components (PR #38).