Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Resources that are specified before the script resource are silently ignored. #650

Closed
2 tasks done
DriesSchaumont opened this issue Feb 16, 2024 · 1 comment
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@DriesSchaumont
Copy link
Contributor

What happened?

When a resources is specified before the first script resource, this resource is silently ignored.

Steps to reproduce

mkdir -p /tmp/test_bug
cd /tmp/test_bug
cat > _viash.yaml << 'HERE'
viash_version: 0.8.4

source: src
target: target
HERE


mkdir -p src/dummycomponent

cat > src/dummycomponent/config.vsh.yaml << 'HERE'
functionality:
  name: myscript
  namespace: "dummycomponent"
  resources:
    - path: /foo.txt
    - type: bash_script
      path: script.sh
      text: |
        ls .

  test_resources:
    - type: bash_script
      path: test.sh
      text: |
        exit 0
platforms:
  - type: docker
    image: ubuntu:latest
  - type: native
  - type: nextflow
HERE

viash ns test -p native -q myscript

Expected behavior

A warning or error is reported.

Relevant log output

viash ns test -p native -q myscript
The working directory for the namespace tests is /tmp/viash_ns_test12536764874782085391
           namespace        functionality             platform            test_name exit_code duration               result
      dummycomponent             myscript               native                start
      dummycomponent             myscript               native              test.sh         0        0              SUCCESS
All 1 configs built and tested successfully

Version

  • OS: Ubuntu 22.04 LTS
  • Viash 0.8.4

Possible solution

No response

Confirmation

  • I have searched the existing issues to make sure this is not a duplicate.
  • I have provided clear and concise information about the bug.

Additional context

No response

@Grifs
Copy link
Collaborator

Grifs commented Apr 3, 2024

Issue will be fixed in Viash 0.8.6

@Grifs Grifs closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants