Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue where if the first resource is not a script, the resource is silently dropped #670

Merged
merged 4 commits into from
Apr 3, 2024

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Apr 2, 2024

Describe your changes

Fix an issue where if the first resource is not a script, the resource is silently dropped

Related issue(s)

Closes #650

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@Grifs Grifs requested a review from rcannood April 2, 2024 10:02
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (6fcf7b6) to head (72f9fc6).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop_0_8     #670   +/-   ##
============================================
  Coverage        88.76%   88.76%           
============================================
  Files              120      120           
  Lines             3630     3630           
  Branches           526      526           
============================================
  Hits              3222     3222           
  Misses             408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Minor suggestion

src/main/scala/io/viash/functionality/Functionality.scala Outdated Show resolved Hide resolved
Co-authored-by: Robrecht Cannoodt <rcannood@gmail.com>
@Grifs
Copy link
Collaborator Author

Grifs commented Apr 2, 2024

LGTM! Minor suggestion

Right, I was thinking of other edge cases ... which totally don't happen in Scala 😛

@rcannood rcannood merged commit 04a63e4 into develop_0_8 Apr 3, 2024
9 checks passed
@Grifs Grifs deleted the fix/non_script_first_resource branch April 3, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants