Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nextflow issues #663

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Fix nextflow issues #663

merged 4 commits into from
Mar 19, 2024

Conversation

rcannood
Copy link
Member

@rcannood rcannood commented Mar 19, 2024

Describe your changes

Related issue(s)

Closes #xxxx

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@rcannood rcannood changed the base branch from main to develop_0_8 March 19, 2024 12:33
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (32468ad) to head (f0ede1a).

Additional details and impacted files
@@             Coverage Diff              @@
##           develop_0_8     #663   +/-   ##
============================================
  Coverage        88.76%   88.76%           
============================================
  Files              120      120           
  Lines             3630     3630           
  Branches           526      526           
============================================
  Hits              3222     3222           
  Misses             408      408           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rcannood rcannood requested a review from Grifs March 19, 2024 13:17
@rcannood rcannood merged commit 8e12373 into develop_0_8 Mar 19, 2024
9 checks passed
@rcannood rcannood deleted the fix/nextflow_issues branch March 19, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants