Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/nextflow concurrency #669

Merged
merged 14 commits into from
Apr 17, 2024
Merged

Fix/nextflow concurrency #669

merged 14 commits into from
Apr 17, 2024

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Mar 29, 2024

Describe your changes

Define 2 variables before a code branch
Fix an additonal similar issue

Related issue(s)

Implements the code mentioned in #605 (comment)

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

@Grifs Grifs requested a review from rcannood March 29, 2024 14:49
@Grifs Grifs changed the base branch from main to develop_0_8 March 29, 2024 14:50
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.76%. Comparing base (9820541) to head (2ef86a9).
Report is 1 commits behind head on develop_0_8.

❗ Current head 2ef86a9 differs from pull request most recent head 58a0047. Consider uploading reports for the commit 58a0047 to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           develop_0_8     #669      +/-   ##
===============================================
- Coverage        88.78%   88.76%   -0.03%     
===============================================
  Files              120      120              
  Lines             3648     3630      -18     
  Branches           527      526       -1     
===============================================
- Hits              3239     3222      -17     
+ Misses             409      408       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go

@Grifs Grifs merged commit df161b0 into develop_0_8 Apr 17, 2024
7 checks passed
@Grifs Grifs deleted the fix/nextflow_concurrency branch April 17, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants