Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --dry_run to viash [ns] test for generating test scripts - On develop_0_8 #676

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

Grifs
Copy link
Collaborator

@Grifs Grifs commented Apr 5, 2024

Describe your changes

Add --dry_run for viash ns test and viash test.
This builds the tests without actually executing the tests.

Backported changes from 0.9.

Related issue(s)

Backport of #665

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New functionality (non-breaking change which adds functionality)
  • Major change (non-breaking change which modifies existing functionality)
  • Minor change (non-breaking change which does not modify existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

Checklist

Requirements:

  • I have read the CONTRIBUTING doc.
  • I have performed a self-review of my code by checking the "Changed Files" tab.
  • My code follows the code style of this project.

Tests:

  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.

Documentation:

  • Proposed changes are described in the CHANGELOG.md.
  • I have updated the documentation accordingly.

Test Environment

tverbeiren and others added 2 commits April 5, 2024 14:03
Make `generateTest` hidden

Simplify: add `--just_generate` to viash ns test

Remove dangling commented line

Add --just_generate to viash test

Add tests

Correction

Update regex for test

Rename --just_generate -> --dry_run

Make --dry_run hidden
@Grifs Grifs changed the title Add ability to generate tests without running them Add --dry_run to viash [ns] test for generating test scripts - On develop_0_8 Apr 5, 2024
@Grifs Grifs requested review from rcannood and tverbeiren April 5, 2024 12:10
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.78%. Comparing base (23314ab) to head (9820541).

Files Patch % Lines
src/main/scala/io/viash/Main.scala 85.71% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           develop_0_8     #676      +/-   ##
===============================================
+ Coverage        88.76%   88.78%   +0.02%     
===============================================
  Files              120      120              
  Lines             3630     3648      +18     
  Branches           526      527       +1     
===============================================
+ Hits              3222     3239      +17     
- Misses             408      409       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tverbeiren tverbeiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Grifs Grifs merged commit 211c383 into develop_0_8 Apr 5, 2024
9 checks passed
@Grifs Grifs deleted the generate_tests_0_8 branch April 18, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants