Skip to content
This repository has been archived by the owner on Dec 8, 2020. It is now read-only.

Fails when toNPCs param is higher than the feature dimension #14

Closed
dweemx opened this issue Nov 24, 2020 · 0 comments · Fixed by vib-singlecell-nf/vsn-pipelines#262, #16 or vib-singlecell-nf/vsn-pipelines#263
Closed

Fails when toNPCs param is higher than the feature dimension #14

dweemx opened this issue Nov 24, 2020 · 0 comments · Fixed by vib-singlecell-nf/vsn-pipelines#262, #16 or vib-singlecell-nf/vsn-pipelines#263
Assignees
@dweemx
Labels
enhancement New feature or request

Comments

@dweemx
Copy link
Contributor

dweemx commented Nov 24, 2020

We should have toNPC be set to:

min(params.pcacv.find_optimal_npcs.toNPC, <max-number-of-feature-dimension>)
@dweemx dweemx added the enhancement New feature or request label Nov 24, 2020
@dweemx dweemx self-assigned this Nov 24, 2020
dweemx added a commit that referenced this issue Nov 24, 2020
@dweemx
Closes #14
2dc53fe
dweemx added a commit to vib-singlecell-nf/vsn-pipelines that referenced this issue Nov 24, 2020
@dweemx
Closes vib-singlecell-nf/pcacv#14
b543a8b
@dweemx dweemx closed this as completed Nov 24, 2020
@cflerin cflerin mentioned this issue Dec 1, 2020
Merged
@dweemx dweemx mentioned this issue Dec 3, 2020
Merged
@cflerin cflerin mentioned this issue Dec 3, 2020
Merged
KrisDavie pushed a commit to vib-singlecell-nf/vsn-pipelines that referenced this issue Dec 8, 2020
@dweemx
Closes vib-singlecell-nf/pcacv#14
fd0f62f 
Former-commit-id: b543a8b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dweemx dweemx

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@dweemx