perform CI on wider range of compiler versions #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vibe.d policy is to only support the last 10 versions, which is better than most other libraries out there. |
|
I'm happy with that. I'll amend the PR |
|
looks like all the jobs passed https://github.com/vibe-d/vibe-core/pull/306/checks, can this be merged? |
SingingBush
force-pushed
the
ci/compiler_versions
branch
from
6e6976b to
d6ee7ac
Compare
|
@SingingBush : Sorry this fell off the radar. I'm happy to merge if you can rebase (and drop 2.089 I guess) |
SingingBush
force-pushed
the
ci/compiler_versions
branch
from
8969916 to
78bd427
Compare
SingingBush
force-pushed
the
ci/compiler_versions
branch
from
78bd427 to
aad4708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that vibe-core successfully builds against a wider range of D compilers. While testing on my fork it seemed that dmd 2.086 to 2.098 (latest) are fine but there were failures on older versions