Fixed integer decoding error in HPACK #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-ludwig
reviewed
Dec 7, 2018
s-ludwig
reviewed
Dec 8, 2018
Contributor
Author
|
Regarding exceptions, I am slowly integrating them because I'm using h2spec to point out the places where they should be. It seems to be a pretty complete tool. |
GallaFrancesco
force-pushed
the
hpack-fix
branch
from
341127c to
ec68c2d
Compare
s-ludwig
approved these changes
Dec 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HPACK library failed when an integer which was more than an octet long was feed to the decoder. To fix this,
toIntegerwas changed todecodeIntegerso that the algorithm defined in the HPACK RFC, section 5.1 is correctly executed.An additional test case and some utilities were added to allow for better testing and exception handling.