Call SoftLaunchSignIn rather than redirecting to the vc2-sl page. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure this'll work out, because SoftLaunchSignIn only checks the soft launch users table, so if they're signed in but not a soft launch user it'll error I think. definitely need to rework sign in a bit - realized today after helping someone out with an issue that we have too many sign in pages/methods, really should just have one method that checks all the tables in a certain order, and redirects |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when visiting the index page while logged in I was getting a redirect to /vc2-sl every time. I took a look at the IndexHandler function and thought, what if we just call SoftLaunchSignIn instead of doing a redirect? It seems to work. Only downside I as far as I can tell is the session gets loaded twice but compared to a redirect that seems not so bad.