New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a simple doc on the convex poly constraints. #264

Merged

viblo merged 4 commits into viblo:master from VeriTas-arch:master

Nov 9, 2024

Contributor

VeriTas-arch commented Nov 7, 2024

Contents

A simple note (line 582) on that polys can only be convex (see issue here Make it more clear from docs that Polys can only be convex, and concave ones will be converted to a "hull" #257 ), yet the doc content can be further discussed.
Some minor changes on the doc to unify the style.

VeriTas-arch added 2 commits

November 7, 2024 13:59


          Add a note on the convex poly constraints.

a8976cb


          minor change

436edad

VeriTas-arch commented

View reviewed changes

Contributor Author

VeriTas-arch left a comment

Most of them are minor changes.


          doc: add more description on convex ploy transformation.

c61b4c9

viblo requested changes

View reviewed changes

Owner

viblo left a comment

A minor comment

pymunk/shapes.py Outdated Show resolved Hide resolved


          review fix

4feef95

VeriTas-arch commented

View reviewed changes

Contributor Author

VeriTas-arch left a comment •

edited

Loading

I think Adding is the correct way here. This is what the user would need pass in to this method, not what the method does.

Well, it is in deed an omission, which is fixed already.

VeriTas-arch requested a review from viblo

November 9, 2024 12:21

viblo approved these changes

View reviewed changes

viblo merged commit e921f53 into viblo:master

5 checks passed

Owner

viblo commented Nov 9, 2024

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet