Conversation
to be more precise about it providing a fixed context to all its included functions.
There was a problem hiding this comment.
Pull Request Overview
This PR renames parametric.context to parametric.fixedTo to more precisely describe its purpose of providing a fixed context to all included functions.
Key Changes
- Renamed
parametric.contexttoparametric.fixedToin the library definition - Updated all usages of the renamed function throughout the codebase
- Enhanced documentation comments to better explain the purpose and behavior of
parametric.fixedTo
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nix/lib.nix | Renames the parametric.context function to parametric.fixedTo and updates its internal usage in parametric.__functor |
| templates/default/modules/aspects/eg/routes.nix | Updates usage from parametric ctx to parametric.fixedTo ctx and expands documentation to clarify the aspect's behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Unlike `den.default` which is `parametric.atLeast` we use `parametric.exactly` here | ||
| # to be more strict and prevent multiple values inclusion. | ||
| # Unlike `den.default` which is `parametric.atLeast` | ||
| # we use `parametric.fixedTo` here, which help us |
There was a problem hiding this comment.
Subject-verb agreement: "help" should be "helps" since the subject "which" refers to the singular parametric.fixedTo.
Suggested change
| # we use `parametric.fixedTo` here, which help us | |
| # we use `parametric.fixedTo` here, which helps us |
| # | ||
| # This aspect, when installed in a `parametric.atLeast` | ||
| # will just forward the same context. | ||
| # The `mutual` helper returns an static configuration which |
There was a problem hiding this comment.
Article usage: "an static" should be "a static" since "static" begins with a consonant sound.
Suggested change
| # The `mutual` helper returns an static configuration which | |
| # The `mutual` helper returns a static configuration which |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to be more precise about it providing a fixed context to all its included functions.