Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the VM configuration to enable switching between GUI and console (TUI) variants. The main change introduces a modular structure where VM configurations can be composed with either graphical or text-based installers, making it easy to toggle between modes by commenting/uncommenting a single line.
- Refactored
eg.vm-bootableto provide bothguiandgraphical-basevariants using a parameterized installer function - Created new
eg.vmaspect that composes VM configurations with appropriate bootable installers and desktop environments - Moved VM variant selection from
igloo.nixto a centralized configuration invm.nix
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| templates/default/modules/vm.nix | Added parameters and configured to use eg.vm._.gui variant (with tui option commented out) |
| templates/default/modules/aspects/igloo.nix | Removed hardcoded VM and desktop includes, delegated to vm.nix |
| templates/default/modules/aspects/eg/vm.nix | New file defining composable VM variants (gui/tui) with appropriate bootable installers |
| templates/default/modules/aspects/eg/vm-bootable.nix | Refactored to use parameterized installer function supporting minimal (tui) and graphical-base (gui) variants |
| templates/default/modules/aspects/defaults.nix | Added OS parameter with deadnix skip annotation for compatibility |
| templates/default/flake.lock | Updated den dependency to newer version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit
modules/vm.nixCloses #82