Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new parametric.withOwn combinator that combines parametric aspect behavior with owned configurations, providing a more intuitive API for defining aspects. The preferred syntax den.lib.parametric { ... } now creates aspects that include both their static configs and parametric includes.
Key changes:
- Added
parametric.withOwnfunction that combinesownedandparametric.atLeastbehaviors - Updated
parametric.__functorto dispatch towithOwnwhen called with attribute sets (previously dispatched tofixedTo) - Renamed parameter from
ctxtoargin__functorfor clarity
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nix/lib.nix | Adds parametric.withOwn combinator and updates __functor to make parametric { ... } an alias for withOwn, with parameter renaming for clarity |
| modules/aspects/dependencies.nix | Refactors to extract context into a named binding and explicitly uses parametric.fixedTo to preserve existing behavior after __functor changes |
| templates/examples/modules/_example/ci/parametric-with-owned.nix | Adds comprehensive test demonstrating the new parametric.withOwn functionality with context forwarding and owned config inclusion |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…onfigs. See discussion: #91 (reply in thread) Fixes #97.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces
parametric.withOwnthat is just aparametric.atLeastthat also includes the aspect owned configs.See discussion: #91 (reply in thread)
Calling
parametric xitself is an alias forparametric.withOwn x.So that both syntax do the same:
and also, *this is the preferred syntax that will be documented, since it is more intuitive and does not surfaces
__functor:Still have to update documentation about this combinator.
Fixes #97.