-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow usb connections via auto-detection #7
Conversation
5a4d471
to
8892b59
Compare
@vicary can you upgrade the Gradle to the latest version? |
Usually you don't need to upgrade the gradle version of the plugin, for the example app you may simply edit the line below to your desired version and rebuild. Line 3 in 6318b88
The example app has workspace deps, it's the best way to install without publishing. You may try installing the locally built plugin via |
@vicary Hi, when I run yarn and:old the application works but when I press search printers, I get an error "Attempt to invoke virtual method 'double java.lang.Double.doubleValue()' on a null object reference" (both on simulator and on physical device, connected to the printer). when running yarn and:new the build fails and I get an error
and also
|
@HatalDev USB shouldn't need to use the search function, you may have to change the code a bit and call I'll take a look at the function bindings in the mean time, there maybe a mismatched argument type on the native layer. |
@vicary I tried setting just one Pressable to use the
I get an error When I try to provide a string as an address, I get an error saying it's not supported for USB connection. |
This comment was marked as outdated.
This comment was marked as outdated.
I can build both archs after fixing the optional parameter binding, I cannot reproduce the error when running printer search though. A new button is added to the example app for easier USB tests. Screen.Recording.2024-08-22.at.22.21.08.mov |
@vicary I've downloaded the latest version, when trying to build I'm getting the following error
it's because of the |
8d6084d
to
577e21b
Compare
@HatalDev I should also update |
@vicary I'm very happy to confirm that the usb printing is working perfectly now, do you need any further help in order to publish it to the main branch, and update the npm package? |
A verbal confirmation that you have tested all 4 environments would be enough, I would otherwise document the untested items. Then we are good to go! |
@vicary I can confirm that both environments of android are working, currently I can't verify it on iOS, but I believe I could do this in couple of days, maybe we can continue with the android for now, as it working exactly as it should. |
I'll add a temporary warning section in the README and release it tomorrow. You may continue commenting in this PR, I'll remove the section if it turns out working! |
edf1bfb
to
f28b8f2
Compare
Fixes #6
@HatalDev Not sure if emulators can proxy through USB connections, but we are good with emulator tests without actual devices if USB works.
You may run the example app for test prints using the commands below, it would be really kind of you to also attach photos for test prints!
Installation
Android
iOS