CI: Enforce -Wall and -Werror

Part 2 of: ornladios#2766 Followup of https://github.com/ornladios/ADIOS2/pull/2639/files Notes from this PR: Wall -Werror enabled for C++ in all builds but: 1. Accent + XL builds 2. Power8 builds 3. Debian buids 4. Using intel compiler translation units that include `nlohmann_json` Signed-off-by: Vicente Adolfo Bolea Sanchez <vicente.bolea@kitware.com>
vicentebolea · Aug 2, 2021 · b61d034 · b61d034
1 parent c5d6778
commit b61d034
Show file tree

Hide file tree

Showing 90 changed files with 453 additions and 175 deletions.
diff --git a/bindings/Python/py11File.cpp b/bindings/Python/py11File.cpp
@@ -216,7 +216,7 @@ pybind11::array File::Read(const std::string &name, const Dims &start,
             m_Stream->Read<std::string>(name, blockID).front();
         pybind11::array_t<char> pyArray(Dims{value.size()});
         std::copy(value.begin(), value.end(), pyArray.mutable_data());
-        return pyArray;
+        return std::move(pyArray);
     }
 
     return Read(name, start, count, 0, 0, blockID);
@@ -270,7 +270,7 @@ pybind11::array File::ReadAttribute(const std::string &name,
         pybind11::array_t<T> pyArray(attribute->m_Elements);                   \
         m_Stream->ReadAttribute<T>(name, pyArray.mutable_data(), variableName, \
                                    separator);                                 \
-        return pyArray;                                                        \
+        return std::move(pyArray);                                             \
     }
     ADIOS2_FOREACH_NUMPY_ATTRIBUTE_TYPE_1ARG(declare_type)
 #undef declare_type

diff --git a/bindings/Python/py11File.tcc b/bindings/Python/py11File.tcc
@@ -91,7 +91,7 @@ pybind11::array File::DoRead(const std::string &name, const Dims &_start,
     }
     m_Stream->m_Engine->Get(variable, pyArray.mutable_data(), Mode::Sync);
 
-    return pyArray;
+    return std::move(pyArray);
 }
 
 } // end namespace py11

diff --git a/cmake/FindPythonModule.cmake b/cmake/FindPythonModule.cmake
@@ -141,7 +141,7 @@ if(PythonModule_${module_NAME}_FOUND AND
   add_library(${module_NAME} INTERFACE)
   add_library(Python::${module_NAME} ALIAS ${module_NAME})
   foreach(inc_var IN LISTS include_vars)
-    target_include_directories(${module_NAME} INTERFACE ${${inc_var}})
+    target_include_directories(${module_NAME} SYSTEM INTERFACE ${${inc_var}})
   endforeach()
   foreach(lib_var IN LISTS library_vars)
     target_link_libraries(${module_NAME} INTERFACE ${${lib_var}})

diff --git a/examples/basics/values/values_write.cpp b/examples/basics/values/values_write.cpp
@@ -71,6 +71,8 @@ int main(int argc, char *argv[])
          */
         // 1. Global constant, same value across processes, constant over time
         adios2::Variable<int> varNproc = io.DefineVariable<int>("Nproc");
+        (void)varNproc; // For the sake of the example we create an unused
+                        // variable
 
         // 2. Global value, same value across processes, varying value over time
         adios2::Variable<int> varStep = io.DefineVariable<int>("Step");

diff --git a/examples/heatTransfer/read_fileonly/heatRead_adios2.cpp b/examples/heatTransfer/read_fileonly/heatRead_adios2.cpp
@@ -72,6 +72,7 @@ int main(int argc, char *argv[])
 
     adios2::Variable<unsigned int> vgndx =
         bpReaderIO.InquireVariable<unsigned int>("gndx");
+    (void)vgndx;
 
     // gndx = vgndx.GetData()[0];
 

diff --git a/examples/hello/bpReader/helloBPReader_nompi.cpp b/examples/hello/bpReader/helloBPReader_nompi.cpp
@@ -36,7 +36,7 @@ int main(int argc, char *argv[])
             bpIO.AvailableVariables(true);
 
         std::cout << "List of variables:";
-        for (const auto variablePair : variables)
+        for (const auto &variablePair : variables)
         {
             std::cout << "  " << variablePair.first;
         }

diff --git a/examples/hello/bpWriter/helloBPSZ.cpp b/examples/hello/bpWriter/helloBPSZ.cpp
@@ -89,6 +89,9 @@ int main(int argc, char *argv[])
         adios2::Attribute<double> attribute =
             bpIO.DefineAttribute<double>("SZ_accuracy", accuracy);
 
+        // To avoid compiling warnings
+        (void)attribute;
+
         /** Engine derived class, spawned to start IO operations */
         adios2::Engine bpFileWriter =
             bpIO.Open("SZexample.bp", adios2::Mode::Write);

diff --git a/examples/hello/bpWriter/helloBPSubStreams.cpp b/examples/hello/bpWriter/helloBPSubStreams.cpp
@@ -67,6 +67,8 @@ int main(int argc, char *argv[])
 
         adios2::Attribute<int> attribute =
             bpIO.DefineAttribute<int>("attrINT", -1);
+        (void)attribute; // For the sake of the example we create an unused
+                         // variable
 
         /** Engine derived class, spawned to start IO operations */
         adios2::Engine bpFileWriter =

diff --git a/examples/hello/bpWriter/helloBPWriter.cpp b/examples/hello/bpWriter/helloBPWriter.cpp
@@ -63,6 +63,8 @@ int main(int argc, char *argv[])
 
         adios2::Variable<std::string> bpString =
             bpIO.DefineVariable<std::string>("bpString");
+        (void)bpString; // For the sake of the example we create an unused
+                        // variable
 
         std::string filename = "myVector_cpp.bp";
         /** Engine derived class, spawned to start IO operations */

diff --git a/examples/hello/hdf5Reader/helloHDF5Reader_nompi.cpp b/examples/hello/hdf5Reader/helloHDF5Reader_nompi.cpp
@@ -93,7 +93,7 @@ int main(int argc, char *argv[])
         const std::map<std::string, adios2::Params> variables =
             h5IO.AvailableVariables();
 
-        for (const auto variablePair : variables)
+        for (const auto &variablePair : variables)
         {
             std::cout << "Name: " << variablePair.first;
             std::cout << std::endl;

diff --git a/scripts/ci/cmake/ci-ascent-gcc.cmake b/scripts/ci/cmake/ci-ascent-gcc.cmake
@@ -14,9 +14,6 @@ env_module(load zeromq)
 set(ENV{CC}  gcc)
 set(ENV{CXX} g++)
 set(ENV{FC}  gfortran)
-set(ENV{CFLAGS}   "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{CXXFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{FFLAGS}   "-Werror -Wno-error=builtin-declaration-mismatch")
 
 set(dashboard_cache "
 ADIOS2_USE_BZip2:BOOL=OFF
@@ -30,6 +27,8 @@ ADIOS2_USE_SST:BOOL=ON
 ADIOS2_USE_SZ:BOOL=OFF
 ADIOS2_USE_ZeroMQ:STRING=ON
 ADIOS2_USE_ZFP:BOOL=OFF
+
+CMAKE_Fortran_FLAGS:STRING=-Werror -Wno-error=builtin-declaration-mismatch
 ")
 
 set(NCPUS 4)

diff --git a/scripts/ci/cmake/ci-debian-sid-openmpi.cmake b/scripts/ci/cmake/ci-debian-sid-openmpi.cmake
@@ -12,6 +12,7 @@ set(ENV{CXXFLAGS} "-Wno-deprecated -Wno-deprecated-declarations")
 set(dashboard_cache "
 ADIOS2_USE_EXTERNAL_DEPENDENCIES:BOOL=ON
 ADIOS2_USE_EXTERNAL_EVPATH:BOOL=OFF
+ADIOS2_USE_EXTERNAL_NLOHMANN_JSON:BOOL=OFF
 ADIOS2_USE_BZip2:BOOL=ON
 ADIOS2_USE_Blosc:BOOL=ON
 ADIOS2_USE_Fortran:BOOL=ON

diff --git a/scripts/ci/cmake/ci-debian-sid.cmake b/scripts/ci/cmake/ci-debian-sid.cmake
@@ -12,6 +12,7 @@ set(ENV{CXXFLAGS} "-Wno-deprecated -Wno-deprecated-declarations")
 set(dashboard_cache "
 ADIOS2_USE_EXTERNAL_DEPENDENCIES:BOOL=ON
 ADIOS2_USE_EXTERNAL_EVPATH:BOOL=OFF
+ADIOS2_USE_EXTERNAL_NLOHMANN_JSON:BOOL=OFF
 ADIOS2_USE_BZip2:BOOL=ON
 ADIOS2_USE_Blosc:BOOL=ON
 ADIOS2_USE_Fortran:BOOL=ON

diff --git a/scripts/ci/cmake/ci-el7-gnu8-ohpc.cmake b/scripts/ci/cmake/ci-el7-gnu8-ohpc.cmake
@@ -10,9 +10,6 @@ env_module(load hdf5)
 set(ENV{CC}  gcc)
 set(ENV{CXX} g++)
 set(ENV{FC}  gfortran)
-set(ENV{CFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{CXXFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{FFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
 
 set(dashboard_cache "
 ADIOS2_USE_BZip2:BOOL=ON
@@ -25,6 +22,10 @@ ADIOS2_USE_Python:BOOL=ON
 ADIOS2_USE_SZ:BOOL=ON
 ADIOS2_USE_ZeroMQ:STRING=ON
 ADIOS2_USE_ZFP:BOOL=ON
+
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
+CMAKE_Fortran_FLAGS:STRING=-Werror -Wno-error=builtin-declaration-mismatch
 ")
 
 set(CTEST_CMAKE_GENERATOR "Unix Makefiles")

diff --git a/scripts/ci/cmake/ci-el7-gnu8-openmpi-ohpc-static.cmake b/scripts/ci/cmake/ci-el7-gnu8-openmpi-ohpc-static.cmake
@@ -16,9 +16,6 @@ env_module(load py3-mpi4py)
 set(ENV{CC}  gcc)
 set(ENV{CXX} g++)
 set(ENV{FC}  gfortran)
-set(ENV{CFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{CXXFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{FFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
 
 set(dashboard_cache "
 BUILD_SHARED_LIBS:BOOL=OFF
@@ -36,6 +33,10 @@ ADIOS2_USE_SZ:BOOL=OFF
 ADIOS2_USE_ZeroMQ:STRING=OFF
 ADIOS2_USE_ZFP:BOOL=OFF
 
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
+CMAKE_Fortran_FLAGS:STRING=-Werror -Wno-error=builtin-declaration-mismatch
+
 MPIEXEC_EXTRA_FLAGS:STRING=--allow-run-as-root --oversubscribe
 MPIEXEC_MAX_NUMPROCS:STRING=${N2CPUS}
 ")

diff --git a/scripts/ci/cmake/ci-el7-gnu8-openmpi-ohpc.cmake b/scripts/ci/cmake/ci-el7-gnu8-openmpi-ohpc.cmake
@@ -16,9 +16,6 @@ env_module(load py3-mpi4py)
 set(ENV{CC}  gcc)
 set(ENV{CXX} g++)
 set(ENV{FC}  gfortran)
-set(ENV{CFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{CXXFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{FFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
 
 set(dashboard_cache "
 ADIOS2_USE_BZip2:BOOL=ON
@@ -32,6 +29,10 @@ ADIOS2_USE_SZ:BOOL=ON
 ADIOS2_USE_ZeroMQ:STRING=ON
 ADIOS2_USE_ZFP:BOOL=ON
 
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
+CMAKE_Fortran_FLAGS:STRING=-Werror -Wno-error=builtin-declaration-mismatch
+
 MPIEXEC_EXTRA_FLAGS:STRING=--allow-run-as-root --oversubscribe
 MPIEXEC_MAX_NUMPROCS:STRING=${N2CPUS}
 ")

diff --git a/scripts/ci/cmake/ci-el7-intel-ohpc.cmake b/scripts/ci/cmake/ci-el7-intel-ohpc.cmake
@@ -10,11 +10,10 @@ env_module(load hdf5)
 set(ENV{CC}  icc)
 set(ENV{CXX} icpc)
 set(ENV{FC}  ifort)
-set(ENV{CFLAGS} -Werror)
-set(ENV{CXXFLAGS} -Werror)
-set(ENV{FFLAGS} "-warn errors")
 
 set(dashboard_cache "
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
 ADIOS2_USE_BZip2:BOOL=ON
 ADIOS2_USE_Blosc:BOOL=ON
 ADIOS2_USE_DataMan:BOOL=ON

diff --git a/scripts/ci/cmake/ci-el7-intel-openmpi-ohpc.cmake b/scripts/ci/cmake/ci-el7-intel-openmpi-ohpc.cmake
@@ -16,9 +16,6 @@ env_module(load py3-mpi4py)
 set(ENV{CC}  icc)
 set(ENV{CXX} icpc)
 set(ENV{FC}  ifort)
-set(ENV{CFLAGS} -Werror)
-set(ENV{CXXFLAGS} -Werror)
-set(ENV{FFLAGS} "-warn errors")
 
 set(dashboard_cache "
 ADIOS2_USE_BZip2:BOOL=ON
@@ -32,6 +29,10 @@ ADIOS2_USE_SZ:BOOL=ON
 ADIOS2_USE_ZeroMQ:STRING=ON
 ADIOS2_USE_ZFP:STRING=ON
 
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
+CMAKE_Fortran_FLAGS:STRING=-warn errors
+
 MPIEXEC_EXTRA_FLAGS:STRING=--allow-run-as-root --oversubscribe
 MPIEXEC_MAX_NUMPROCS:STRING=${N2CPUS}
 ")

diff --git a/scripts/ci/cmake/ci-el7-spack.cmake b/scripts/ci/cmake/ci-el7-spack.cmake
@@ -26,6 +26,9 @@ ADIOS2_USE_EXTERNAL_DEPENDENCIES:BOOL=ON
 ADIOS2_USE_EXTERNAL_GTEST:BOOL=OFF
 ADIOS2_USE_EXTERNAL_PUGIXML:BOOL=OFF
 
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
+
 MPIEXEC_EXTRA_FLAGS:STRING=--allow-run-as-root --oversubscribe
 MPIEXEC_MAX_NUMPROCS:STRING=${N2CPUS}
 ")

diff --git a/scripts/ci/cmake/ci-el7.cmake b/scripts/ci/cmake/ci-el7.cmake
@@ -3,9 +3,6 @@
 set(ENV{CC}  gcc)
 set(ENV{CXX} g++)
 set(ENV{FC}  gfortran)
-set(ENV{CFLAGS} -Werror)
-set(ENV{CXXFLAGS} -Werror)
-set(ENV{FFLAGS} -Werror)
 
 set(dashboard_cache "
 ADIOS2_USE_BZip2:STRING=ON
@@ -16,6 +13,9 @@ ADIOS2_USE_MPI:STRING=OFF
 ADIOS2_USE_Python:STRING=ON
 ADIOS2_USE_ZeroMQ:STRING=ON
 ADIOS2_USE_ZFP:STRING=ON
+
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
 ")
 
 set(CTEST_CMAKE_GENERATOR "Unix Makefiles")

diff --git a/scripts/ci/cmake/ci-macos1014-xcode103-ninja.cmake b/scripts/ci/cmake/ci-macos1014-xcode103-ninja.cmake
@@ -7,6 +7,9 @@ set(dashboard_cache "
 ADIOS2_USE_Fortran:BOOL=ON
 ADIOS2_USE_MPI:BOOL=OFF
 ADIOS2_USE_Python:BOOL=ON
+
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
 ")
 
 set(ENV{MACOSX_DEPLOYMENT_TARGET} "10.14")

diff --git a/scripts/ci/cmake/ci-macos1014-xcode103-openmpi-make.cmake b/scripts/ci/cmake/ci-macos1014-xcode103-openmpi-make.cmake
@@ -11,6 +11,9 @@ set(dashboard_cache "
 ADIOS2_USE_Fortran:BOOL=ON
 ADIOS2_USE_MPI:STRING=ON
 
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
+
 MPIEXEC_EXTRA_FLAGS:STRING=--oversubscribe
 MPIEXEC_MAX_NUMPROCS:STRING=4
 ")

diff --git a/scripts/ci/cmake/ci-macos1015-xcode111-make.cmake b/scripts/ci/cmake/ci-macos1015-xcode111-make.cmake
@@ -7,6 +7,9 @@ set(dashboard_cache "
 ADIOS2_USE_Fortran:BOOL=ON
 ADIOS2_USE_MPI:BOOL=OFF
 ADISO2_USE_Python:BOOL=ON
+
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
 ")
 
 set(ENV{MACOSX_DEPLOYMENT_TARGET} "10.15")

diff --git a/scripts/ci/cmake/ci-macos1015-xcode111-openmpi-ninja.cmake b/scripts/ci/cmake/ci-macos1015-xcode111-openmpi-ninja.cmake
@@ -11,6 +11,9 @@ set(dashboard_cache "
 ADIOS2_USE_Fortran:BOOL=ON
 ADIOS2_USE_MPI:STRING=ON
 
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
+
 MPIEXEC_EXTRA_FLAGS:STRING=--oversubscribe
 MPIEXEC_MAX_NUMPROCS:STRING=4
 ")

diff --git a/scripts/ci/cmake/ci-ubuntu1804-spack.cmake b/scripts/ci/cmake/ci-ubuntu1804-spack.cmake
@@ -7,9 +7,6 @@ math(EXPR N2CPUS "${NCPUS}*2")
 set(ENV{CC}  gcc)
 set(ENV{CXX} g++)
 set(ENV{FC}  gfortran)
-set(ENV{CFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{CXXFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
-set(ENV{FFLAGS} "-Werror -Wno-error=builtin-declaration-mismatch")
 
 set(dashboard_cache "
 ADIOS2_USE_BZip2:BOOL=ON
@@ -29,6 +26,9 @@ ADIOS2_USE_EXTERNAL_DEPENDENCIES:BOOL=ON
 ADIOS2_USE_EXTERNAL_GTEST:BOOL=OFF
 ADIOS2_USE_EXTERNAL_PUGIXML:BOOL=OFF
 
+CMAKE_C_FLAGS:STRING=-Wall
+CMAKE_CXX_FLAGS:STRING=-Wall
+
 MPIEXEC_EXTRA_FLAGS:STRING=--allow-run-as-root --oversubscribe
 MPIEXEC_MAX_NUMPROCS:STRING=${N2CPUS}
 ")

diff --git a/source/adios2/engine/bp5/BP5Reader.cpp b/source/adios2/engine/bp5/BP5Reader.cpp
@@ -24,8 +24,8 @@ namespace engine
 BP5Reader::BP5Reader(IO &io, const std::string &name, const Mode mode,
                      helper::Comm comm)
 : Engine("BP5Reader", io, name, mode, std::move(comm)), m_MDFileManager(m_Comm),
-  m_FileMetaMetadataManager(m_Comm), m_DataFileManager(m_Comm),
-  m_MDIndexFileManager(m_Comm), m_ActiveFlagFileManager(m_Comm)
+  m_DataFileManager(m_Comm), m_MDIndexFileManager(m_Comm),
+  m_FileMetaMetadataManager(m_Comm), m_ActiveFlagFileManager(m_Comm)
 {
     PERFSTUBS_SCOPED_TIMER("BP5Reader::Open");
     Init();

diff --git a/source/adios2/engine/bp5/BP5Writer.cpp b/source/adios2/engine/bp5/BP5Writer.cpp
@@ -33,7 +33,7 @@ BP5Writer::BP5Writer(IO &io, const std::string &name, const Mode mode,
                      helper::Comm comm)
 : Engine("BP5Writer", io, name, mode, std::move(comm)), m_BP5Serializer(),
   m_FileDataManager(m_Comm), m_FileMetadataManager(m_Comm),
-  m_FileMetaMetadataManager(m_Comm), m_FileMetadataIndexManager(m_Comm)
+  m_FileMetadataIndexManager(m_Comm), m_FileMetaMetadataManager(m_Comm)
 {
     PERFSTUBS_SCOPED_TIMER("BP5Writer::Open");
     m_IO.m_ReadStreaming = false;
@@ -138,6 +138,7 @@ uint64_t BP5Writer::WriteMetadata(
 void BP5Writer::WriteData(format::BufferV *Data)
 {
     format::BufferV::BufferV_iovec DataVec = Data->DataVec();
+    (void)DataVec;
     switch (m_Parameters.AggregationType)
     {
     case (int)AggregationType::EveryoneWrites:
@@ -511,6 +512,7 @@ void BP5Writer::InitAggregator()
     else
     {
         size_t numNodes = m_AggregatorTwoLevelShm.PreInit(m_Comm);
+        (void)numNodes;
         m_AggregatorTwoLevelShm.Init(m_Parameters.NumAggregators,
                                      m_Parameters.NumSubFiles, m_Comm);
 
@@ -639,7 +641,6 @@ void BP5Writer::InitTransports()
         m_FileMetadataManager.OpenFiles(m_MetadataFileNames, m_OpenMode,
                                         m_IO.m_TransportsParameters, false);
 
-        uint64_t WriterCount = m_Comm.Size();
         m_FileMetadataIndexManager.OpenFiles(
             m_MetadataIndexFileNames, m_OpenMode, m_IO.m_TransportsParameters,
             false);

diff --git a/source/adios2/engine/dataman/DataManMonitor.cpp b/source/adios2/engine/dataman/DataManMonitor.cpp
@@ -12,7 +12,7 @@
 #include <fstream>
 #include <iostream>
 #include <math.h>
-#include <nlohmann/json.hpp>
+#include <nlohmann_json.hpp>
 
 namespace adios2
 {

diff --git a/source/adios2/engine/dataman/DataManMonitor.h b/source/adios2/engine/dataman/DataManMonitor.h
@@ -76,7 +76,6 @@ class DataManMonitor
     bool m_WriterThreading = false;
 
     bool m_Verbose = true;
-    bool m_JsonOutput = true;
 };
 
 } // end namespace engine

diff --git a/source/adios2/engine/hdf5/HDF5ReaderP.cpp b/source/adios2/engine/hdf5/HDF5ReaderP.cpp
@@ -202,8 +202,8 @@ size_t HDF5ReaderP::ReadDataset(hid_t dataSetId, hid_t h5Type,
             size_t typesize = H5Tget_size(h5Type);
 
             char *val = (char *)(calloc(typesize, sizeof(char)));
-            hid_t ret2 = H5Dread(dataSetId, h5Type, memDataSpace, fileSpace,
-                                 H5P_DEFAULT, val);
+            H5Dread(dataSetId, h5Type, memDataSpace, fileSpace, H5P_DEFAULT,
+                    val);
 
             ((std::string *)values)->assign(val, typesize);
             free(val);