-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate ZipLongest
to Source Generator
#162
Conversation
Codecov ReportBase: 87.19% // Head: 87.32% // Increases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
==========================================
+ Coverage 87.19% 87.32% +0.12%
==========================================
Files 190 188 -2
Lines 5122 5040 -82
Branches 1191 1177 -14
==========================================
- Hits 4466 4401 -65
+ Misses 359 346 -13
+ Partials 297 293 -4 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Async version cannot use this technique and cannot be improved further
Comparison with morelinq/MoreLINQ#715:
See also conversation: morelinq/MoreLINQ#905 |
This PR migrates
ZipLongest
to source generator. This has several advantages:ZipLongest
MoveNext
callsValueTuple
version ofZipLongest
Tests have been updated to acknowledge that different versions do not share common implementations and test each one independently.
Fixes #157
Fixes #160