Add text output to console #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+31
to
+45
| var currentVersion = Cldr.Instance.CurrentVersion(); | ||
| Console.WriteLine($"Current CLDR data version: {currentVersion}"); | ||
| var latestVersion = await Cldr.LatestVersionAsync(); | ||
| Console.WriteLine($"Latest CLDR data version: {latestVersion}"); | ||
|
|
||
| if (currentVersion < latestVersion) | ||
| { | ||
| Console.WriteLine("Updating CLDR data. This may take some time."); | ||
| await Cldr.Instance.DownloadAsync(latestVersion); | ||
| Console.WriteLine("CLDR data was updated."); | ||
| } | ||
| else | ||
| { | ||
| Console.WriteLine("The CLDR data is up to date."); | ||
| } |
There was a problem hiding this comment.
This should use ILogger
There was a problem hiding this comment.
Is ILogger available before DI is resolved?
vicr123
force-pushed
the
features/console-head
branch
from
c59827a to
93c4b03
Compare
vicr123
force-pushed
the
features/console-head
branch
from
93c4b03 to
890347b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a heading in console output when Parlance starts up, and gives information about the current status of the CLDR data.