Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support the "format" standard built-in tags (without the OpenAPI ones) #399

Merged
merged 11 commits into from
Nov 9, 2023
Merged

feat: support the "format" standard built-in tags (without the OpenAPI ones) #399

merged 11 commits into from
Nov 9, 2023

Conversation

magicDGS
Copy link
Contributor

@magicDGS magicDGS commented Nov 8, 2023

Fixes #396

@magicDGS magicDGS mentioned this pull request Nov 8, 2023
Closed
@CarstenWickner
Copy link
Member

Hi @magicDGS,

I like the overall approach
I'll slightly tweak some names, move the paragraph in the documentation, and mention it in the CHANGELOG, but I can do that after the merge.
Thank you very much for your contribution. 😄

@CarstenWickner CarstenWickner merged commit d1e2502 into victools:main Nov 9, 2023
10 checks passed
@CarstenWickner CarstenWickner mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarstenWickner CarstenWickner CarstenWickner approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the "format" string tag without the other OpenAPI format-values
2 participants
@magicDGS @CarstenWickner