#438 Upgrade to support jdk17 #477
Conversation
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (9.77 -> 9.77)
View detailed results in CodeScene
Absence of Expected Change Pattern
- jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/MethodScope.java is usually changed with: jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/FieldScope.java
- jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGeneratorConfigImpl.java is usually changed with: jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/SchemaGeneratorConfig.java
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (9.77 -> 9.77)
View detailed results in CodeScene
Absence of Expected Change Pattern
- jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/MethodScope.java is usually changed with: jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/FieldScope.java
- jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGeneratorConfigImpl.java is usually changed with: jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/SchemaGeneratorConfig.java
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (9.77 -> 9.77)
View detailed results in CodeScene
Absence of Expected Change Pattern
- jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/MethodScope.java is usually changed with: jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/FieldScope.java
- jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGeneratorConfigImpl.java is usually changed with: jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/SchemaGeneratorConfig.java
There was a problem hiding this comment.
I appreciate all the work that went into this, I'm just not sure how to best approach abandoning JDK 11 support.
The library could be used in bigger applications, that might still be tied to JDK 11.
I'm pondering a separate branch to keep supporting both JDK versions or simply making this a new major version, that expects JDK 17+, since there aren't many changes being added anyway, that an application still on JDK 11 couldn't live without.
That's why I haven't acted upon your PR yet.
I'm undecided how to tackle it.
| @@ -12,6 +12,7 @@ | |||
| <packaging>pom</packaging> | |||
|
|
|||
| <properties> | |||
| <maven.compiler.release>17</maven.compiler.release> | |||
There was a problem hiding this comment.
suggestion: Irrelevant compiler setting for a BOM.
| <maven.compiler.release>17</maven.compiler.release> |
...enerator/src/main/java/com/github/victools/jsonschema/generator/impl/AttributeCollector.java
Show resolved
Hide resolved
...src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGenerationContextImpl.java
Show resolved
Hide resolved
...src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGenerationContextImpl.java
Show resolved
Hide resolved
|
IMHO, if an application still uses Java 11, it's probably not going to use the most recent libraries either. My vote is to abandon support for Java 11 ASAP if it causes issues or hinders the development. |
There was a problem hiding this comment.
✅ Code Health Quality Gates: OK
Change in average Code Health of affected files: -0.00 (9.77 -> 9.77)
View detailed results in CodeScene
Absence of Expected Change Pattern
- jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/MethodScope.java is usually changed with: jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/FieldScope.java
- jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/impl/SchemaGeneratorConfigImpl.java is usually changed with: jsonschema-generator/jsonschema-generator/src/main/java/com/github/victools/jsonschema/generator/SchemaGeneratorConfig.java
try to build with JDK17 since it's LTS version and widely used in organizations