Ended because API returned an empty page (Fix) #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem regarding API returning an empty page
Summary - Since everything is done in chunks of 25, if the system finds 1-25 messages it will delete them. If it finds 0 messages (but total-offset>0) it will increment the offset by 25 to skip the 25 non-deletable messages and recurse. If (total-offset <= 0) then it will still end.
Incrementing the offset by 1 each time is not ideal because you'll still be traversing huge chunks of dead messages.
I had the original problem described above earlier - I've been running this for several hours now and have deleted thousands of messages with no errors and no API-induced slowdowns.
Credit: PinkyLaRue & larryqiann
This change is