refactor: reduce number of @matchs #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victornpb
added a commit
that referenced
this pull request
Apr 29, 2022
Bump Discord API version to version 9 and add more message type to be deleted PR looks good (#223 by VictorienXP) Add wildcard subdomain for discord.com match on the userscript (#224 by VictorienXP) Fix bug where process is prematurely stopped due to receiving a full array of skippedMessages (#323 by aijorgenson) fix: stricter url matching (#335 by SethFalco) refactor: reduce number of @matchs (#336 by SethFalco) Removed duplicate OR operator (#338 by aydinyal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this should work. I tested the base discord.com domain as well and can confirm that was fine.
Didn't know about canary and ptb, but this should cover all of them in 3 lines instead of 9.
Sorry to mention you, Mr. Matchs. ^-^'
Didn't realize GitHub would convert the
@in the commit to a mention.