fixed getting token and author id

[titushm]

No description provided.

[abigailwillow]

Hi! Thanks for your PR! I've noticed you've opened 3 PRs over the last 6 hours. Is there anything you need help with regarding your PRs? This one looks like a good improvement over the other two. I also wanted to let you know that the author of this repository is currently not very active and it might take a while to have your PR merged!

[titushm]

Hi, yea you can ignore the previous two, I found issues with my method every time after I had sent a pr. I believe this should be final and wont need any more tweaking. anyway thanks for the reply!

[abigailwillow]

For future reference, it's not necessary to close and open new PRs. You can rebase commits to "undo", "redo", or edit commits that you've already pushed. Most users prefer PRs with few commits so this can be useful to squash multiple commits into one as well.

Also check out GitLens, it provides some nice visual tools for working with Git within Visual Studio Code. If you use a different code editor I'm sure there's similar extensions available.

Hope this helps!

[victornpb]

Hi, can you explain what this code does? I just tested the current implementation, and it is not broken. It's been reliable for quite some time.

[Aida-Enna]

+1 for current code working

[victornpb]

I tested this and it works, I will keep this in case the current implementation stops working.

[titushm]

I'm not sure exactly when it causes the error but I think if you open up Dev tools and look at the localstorage then it seems to hide the token from the localstorage

[titushm]

I will test later

[victornpb]

I'm not sure exactly when it causes the error but I think if you open up Dev tools and look at the localstorage then it seems to hide the token from the localstorage

Yes, that's right, my implementation fails if you open devTools. It seems that they recently added code to prevent people from running scripts directly in the console which makes sense.

I'm not entirely sure how they are able to detect devTools open TBH, but even tho it's kinda annoying when I'm trying to debug undiscord, I think its better to keep as is because the chance of it stopping working is smaller.

your method of injecting a module in the webpack runtime is clever ngl.

[titushm]

Does it detect the size of the discord window?
If you set devtools to be a separate window can it still detect it?

[victornpb]

Does it detect the size of the discord window? If you set devtools to be a separate window can it still detect it?

Yes, you are correct, it works if you detach the devTools window.

So they are probably doing something like:

// on window resize
isDevToolsOpen = ((window.outerWidth - window.innerWidth) + (window.outerHeight - window.innerHeight)) > 500;
    
if (isDevToolsOpen) delete localStorage;

[TheRedstoneRadiant]

Can this please be merged?

I use the copy/paste version very often and have to manually get the token via network requests each time.

[titushm]

Can this please be merged?

I use the copy/paste version very often and have to manually get the token via network requests each time.

It was merged at one point but was reverted as to maintain parity with getting the user id / not enough people had an issue with the old system

[titushm]

I have the working version on my GitHub https://github.com/titushm/undiscord-patched

[titushm]

@victornpb i have rewritten my pull request to use webpack as a fallback method if the auth token cannot be found in localstorage

[AreaZR]

Any updates on this?

[titushm]

Any updates on this?

The owner of this repo is not very active so might take a while if a pull request was to happen