Add accountMode setting for energy meters, fix et340 with phase balancing grids #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e individual energy counters for each phase of the meter will be ignored, this fix the incorrect behaviour for ET340 devices when compared to phase balancing grid meters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have done some calculations and compared them with my providers grid meter readings, this should resolve the issue.
This PR is a draft, I'm unable to buiild it right now, as the venus sdk does not work on my M2 Macbook and I also can't figure out a way to build it on my cerbo :(
In this screenshot, the green numbers (ET340 kWh Total) are correct, the red (ET340 kWh per Phase) are wrong and the red are those that are counted for the VRM sums, to resolve this I propose to ignore the per phase readings and spread the total readings on the phases (this is how it works for em24).
Changes:
feat(accountingMode): add setting "accountingMode", if set to sum, the individual energy counters for each phase of the meter will be ignored, this fix the incorrect behaviour for ET340 devices when compared to phase balancing grid meters