Add SystemBatteryDeviceModel and SystemBatteryDelegate #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type refers to the battery that is currently active according to com.victronenergy.system/ActiveBatteryService, so rename the type to make this more clear.
This avoids duplicating code between BatteryListPage and PageSettingsBatteries.
This avoids duplicating code between BatteryListPage and PageSettingsBatteries.
blammit
force-pushed
the
blam/battery-refactor
branch
from
4e907dd to
80554fc
Compare
| width: parent.width | ||
| height: Theme.geometry_batteryListPage_item_height | ||
|
|
||
| Column { |
There was a problem hiding this comment.
Mixing Positioners and Layouts - I assume this is intentional
| source: "qrc:/images/icon_arrow_32.svg" | ||
| rotation: 180 | ||
| color: pressArea.containsPress ? Theme.color_listItem_down_forwardIcon : Theme.color_listItem_forwardIcon | ||
| opacity: pressArea.enabled ? 1 : 0 |
There was a problem hiding this comment.
Assume visible isn't used here because it would interfere with the layout?
|
|
||
| const batteryList = value | ||
| let batteryUids = [] | ||
| let i |
There was a problem hiding this comment.
move let i into the respective for loops
| } | ||
| footer: SettingsColumn { | ||
| width: parent ? parent.width : 0 | ||
| topPadding: Theme.geometry_gradientList_spacing |
There was a problem hiding this comment.
does the container not have a spacing property for this purpose?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do some refactoring to avoid duplicating model/delegate code between BatteryListPage and PageSettingsBatteries.